fix: volumemgr: update VRS every time VS changes

[europaul]

This is the only place in the code base where volume ref status was not updated after volume status was potentially changed, which led to some changes in volumes to being seen by edge apps.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.90%. Comparing base (2e69dc3) to head (a529f4f).
Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4498   +/-   ##
=======================================
  Coverage   20.90%   20.90%           
=======================================
  Files          13       13           
  Lines        2894     2894           
=======================================
  Hits          605      605           
  Misses       2163     2163           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eriknordmark]

LGTM

[deitch]

Am I correct that this is not just updating the volume ref status, but also placing the updates inside the needUpdateVol logic, and only if something changed? Before, it always updated the volumeStatusRefCount and always published the volume status and the app disk metrics. Now, it does so only if the volume needs an update, and only if doUpdateVol() returned changed.

The logic change seems correct to me, but I want too be sure we capture it, at least in the PR comment.

[deitch]

Also one failing test. I will restart it.

[europaul]

Am I correct that this is not just updating the volume ref status, but also placing the updates inside the needUpdateVol logic, and only if something changed? Before, it always updated the volumeStatusRefCount and always published the volume status and the app disk metrics. Now, it does so only if the volume needs an update, and only if doUpdateVol() returned changed.

@deitch that's correct. I didn't mention it in the description, because it's not part of the fix logic. However calling those functions only when volume status changes is consistent with the rest of the code base - so we do the same here.