Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring Installation Section #202

Closed
wants to merge 2 commits into from
Closed

Conversation

tanneberger
Copy link
Member

@tanneberger tanneberger commented Dec 16, 2023

Things Done

  • this reorders a couple of sections:
    1.) Lingua-Franca Compiler (LFC)
    2.) Lingo
    3.) VScode
    4.) Epoch

    I changed the ordering because most of the people are interested in installing the compiler, so this should be definitely the first section.

@tanneberger tanneberger force-pushed the lfc-first-epoch-second branch from 46b8d77 to 532ccaa Compare December 16, 2023 01:26
@tanneberger tanneberger self-assigned this Dec 16, 2023
@tanneberger tanneberger added the enhancement New feature or request label Dec 16, 2023
@tanneberger tanneberger requested a review from lhstrh December 16, 2023 01:33
@lhstrh lhstrh requested a review from cmnrd December 16, 2023 06:51
@lhstrh
Copy link
Member

lhstrh commented Jan 31, 2024

I've looked at this, but I'm not sure I agree that most users would first look for the CLI tools. My guess is that most people are interested in the VS Code extension... I've also requested a review from @cmnrd since he most recently worked on these docs.

@lhstrh lhstrh mentioned this pull request Jan 31, 2024
Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that we shouldn't change the order. Could you concert it back to the old order?


```
cargo install lingua-franca
PATH = $PATH:~/.cargo/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an export command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the export is not necessary ;D it also works without it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, right. It doen't work with the spaces around the = though.

Suggested change
PATH = $PATH:~/.cargo/bin
PATH=$PATH:~/.cargo/bin


If you'd like to contribute to Lingua Franca, you can find details about the recommended developer setup here.

## Lingo the Lingua-Franca Package-Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Lingo the Lingua-Franca Package-Manager
## Lingo

@tanneberger
Copy link
Member Author

Ok will revert to old order.

@tanneberger
Copy link
Member Author

tanneberger commented Apr 1, 2024

Closing this issue, because the only thing this pr did was changing the order

@tanneberger tanneberger closed this Apr 1, 2024
@cmnrd
Copy link
Contributor

cmnrd commented Apr 2, 2024

Didn't this also add install instructions for lingo? Those are currently missing on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants