Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct refactoring for actions and ports #26

Closed
wants to merge 1 commit into from
Closed

Conversation

edwardalee
Copy link
Contributor

This PR refactors the structs associated with ports and actions to make a clearer distinction between fields that are user-visible and those that are only used internally by the runtime. It also adds a parent pointer to the struct for actions. There is a corresponding PR in both lingua-franca and reactor-c.

@edwardalee edwardalee requested a review from erlingrj May 20, 2023 21:31
Copy link

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lhstrh
Copy link
Member

lhstrh commented May 21, 2023

This has been subsumed by changes in lf-lang/reactor-c#216.

@lhstrh lhstrh closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants