Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CGenerator.xtend #1011

Merged
merged 45 commits into from
Mar 11, 2022
Merged

Refactor CGenerator.xtend #1011

merged 45 commits into from
Mar 11, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Mar 9, 2022 •
edited
Loading

As part of the effort to port CGenerator.xtend to java, I have refactored some of it into separate files.

This PR has reached a good stopping point and is ready to merge.

housengw added 20 commits March 7, 2022 16:27
@housengw
refactor writeDockerFile
38bfaa5
@housengw
merge multiple if statements into 1
590590d
@housengw
factor out corefiles
48c2a5c
@housengw
add semicolon to import statements
2745857
@housengw
factor out action initializers
f876d21
@housengw
refactor generateActionInitializations
60363f4
@housengw
factor out rootType
695599f
@housengw
factor out generateTokenInitializer
97d2323
@housengw
factor out timer initializations
7f30db6
@housengw
factor out state initialization
71f1cc4
@housengw
bug fix
7a25b8d
@housengw
factor out some of the tracing stuff
0273c34
@housengw
factor out CParameters declarations
809a475
@housengw
factor out state vars and actions declarations in self struct
59c7ee3
@housengw
factor out generateInput and Output declarations in self struct
d507029
@housengw
factor out modes declarations in self struct
36218c5
@housengw
factor out git status
9f2a2bd
@housengw
factor out main function
e6aa6a8
@housengw
factor out docker compose stuff
869c3fc
@housengw
refactor docker compose files generation
2f25de7
@housengw housengw changed the title Xtend to java c generator Port CGenerator.xtend to java Mar 9, 2022
edwardalee
edwardalee approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great refactoring! One issue throughout is this:

Each file should have a class comment with a short description of the class and author information.

org.lflang/src/org/lflang/generator/DockerComposeGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CActionGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CCoreFilesUtils.java Show resolved Hide resolved
@housengw housengw marked this pull request as ready for review March 10, 2022 08:59
@housengw housengw changed the title Port CGenerator.xtend to java Refactor CGenerator.xtend Mar 10, 2022
@housengw housengw requested a review from lhstrh March 10, 2022 18:16
lhstrh
lhstrh approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @edwardalee; this looks great! I've flagged the locations where class comments and author info are missing. If you could correct those, that'd be great.

org.lflang/src/org/lflang/generator/c/CModesGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CNetworkGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CParameterGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CPortGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CTimerGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CTracingGenerator.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/InteractingContainedReactors.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/python/PythonPreambleGenerator.java Show resolved Hide resolved
@lhstrh lhstrh merged commit e4567a4 into master Mar 11, 2022
@lhstrh lhstrh deleted the xtend-to-java-c-generator branch March 11, 2022 00:31
@lhstrh lhstrh restored the xtend-to-java-c-generator branch March 11, 2022 00:31
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@housengw @edwardalee @lhstrh