Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and add federated execution tests for TypeScript target #1062

Merged
merged 6 commits into from
Apr 19, 2022
Merged

Update and add federated execution tests for TypeScript target #1062

merged 6 commits into from
Apr 19, 2022

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Mar 27, 2022

Relevant PR: lf-lang/reactor-ts#91

@hokeun hokeun mentioned this pull request Mar 27, 2022
Merged
@hokeun hokeun requested review from lhstrh and edwardalee March 27, 2022 13:00
edwardalee
edwardalee approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look OK to me. One minor issue is that we settled on the following comment style:

/**
 * Text goes here...
 */

rather than this:

/** Text shouldn't go here.
 *   more text.
 */

@hokeun
Copy link
Member Author

hokeun commented Mar 31, 2022

Tests look OK to me. One minor issue is that we settled on the following comment style:

/**
 * Text goes here...
 */

rather than this:

/** Text shouldn't go here.
 *   more text.
 */

Thank you @edwardalee ! Fixed these in 7e04870.

@cmnrd cmnrd merged commit bde72b9 into master Apr 19, 2022
@cmnrd cmnrd deleted the ts-federated branch April 19, 2022 14:13
@lhstrh lhstrh changed the title Update and add federated execution tests for TypeScript target. Update and add federated execution tests for TypeScript target May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokeun @edwardalee @cmnrd