Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation tests for ports in main or federated reactor #1091

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add validation tests for ports in main or federated reactor #1091

merged 1 commit into from
Apr 12, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Apr 11, 2022 •
edited
Loading

I thought of adding these tests after reading #969 and #618

@housengw housengw force-pushed the add-top-level-reactor-port-check branch from 4681b05 to 7a53572 Compare April 12, 2022 17:59
@housengw housengw self-assigned this Apr 12, 2022
@housengw housengw requested a review from lhstrh April 12, 2022 22:27
lhstrh
lhstrh approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@housengw housengw merged commit 0825c08 into master Apr 12, 2022
@housengw housengw deleted the add-top-level-reactor-port-check branch April 12, 2022 22:33
@lhstrh
Copy link
Member

lhstrh commented Apr 12, 2022

Thanks for adding the labels :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees

@housengw housengw

Labels
testing validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@housengw @lhstrh