-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for state variables in diagrams #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! But while trying this, I noticed one small problem. If a state variable is initialized by target code, this target code is omitted. So if we have state foo: int({=bar=})
this is rendered as foo: int()
. While I think it is a good idea not to print the verbatim target code in the diagrams, currently it looks like the variable is not initialized. Perhaps, instead, we could insert {=...=}
as a placeholder?
If we show the funny brackets we might as well show what's between them, no? |
I agree with @lhstrh. I don't think we should omit or replace target code. I will revise the PR accordingly; also adjusting reactor parameters to be displayed consistently. |
Does anything need to change in the VS Code extension to enable this feature (besides updating the submodule)? |
No, this feature will work on both platforms out-of-the-box. |
Effective in states variables and parameters.
Should be fixed now |
That's great! What you're doing now works well. Note that we already have an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Added option to display state variables in reactors. Will be off by default.
Also includes some minor unrelated improvements in the diagrams package.