Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TS generator to support serialization of communication in federated execution #1125

Merged
merged 13 commits into from
May 10, 2022
Merged

Change TS generator to support serialization of communication in federated execution #1125

merged 13 commits into from
May 10, 2022

Conversation

CloverCho
Copy link
Collaborator

@CloverCho CloverCho commented Apr 28, 2022 •
edited by hokeun
Loading

Currently federates of reactor-ts only could send/receive string types, so input/output port is constrained to string type
It is because they use the Buffer class to contain messages, and translate it to String for communication
In this request,

  1. toString() is removed in the network message body
  2. improve generating action instantiations to cover the case when the action is in federate
  3. Add tests for using number types for input/output ports.

Reactor-ts PR to be merged together with this PR: lf-lang/reactor-ts#99

@CloverCho CloverCho requested review from hokeun and lhstrh April 28, 2022 22:25
@lhstrh lhstrh changed the title Chage TS generator to support serialization of communication in federate execution Change TS generator to support serialization of communication in federate execution Apr 28, 2022
@hokeun hokeun mentioned this pull request May 8, 2022
Merged
hokeun
hokeun approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @lhstrh Could you please take another look at this PR as well? Thanks!

lhstrh
lhstrh approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh lhstrh merged commit bea7c3d into master May 10, 2022
@lhstrh lhstrh deleted the ts-serialization branch May 10, 2022 06:49
@lhstrh lhstrh changed the title Change TS generator to support serialization of communication in federate execution Change TS generator to support serialization of communication in federated execution May 10, 2022
@petervdonovan petervdonovan added enhancement Enhancement of existing feature typescript Related to TypeScript target labels May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@hokeun hokeun hokeun approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature typescript Related to TypeScript target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CloverCho @hokeun @lhstrh @petervdonovan