Repair LSP tests #1199
Merged
Repair LSP tests #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
force-pushed
the
lsp-test-fix
branch
2 times, most recently
from
8c41002 to
f05c71b
Compare
petervdonovan
force-pushed
the
lsp-test-fix
branch
from
f05c71b to
a3837d8
Compare
lhstrh
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP tests failed due to an issue that I had thought I had fixed. I think I had an
off-by-one error/off-by-two error?!/off-by-one error/combination of off-by-one error and namespacing error in one of the heuristics that I had written into the tests. This fixes the mistake.I acknowledge that these tests probably were not written very well. With their current design they have been tricky to get right... Apologies.