Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Python methods #1230

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Support for Python methods #1230

merged 7 commits into from
Jun 14, 2022

Conversation

Soroosh129
Copy link
Contributor

This adds support for methods in the Python target.

@Soroosh129 Soroosh129 requested review from lhstrh and edwardalee June 13, 2022 19:46
@Soroosh129
Copy link
Contributor Author

I moved method tests for the Cpp and C targets out of the target folder because it seems like a language feature that all targets could support.

edwardalee
edwardalee approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lhstrh
lhstrh approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Cool! ..only left a remark regarding an odd comment.

org.lflang/src/org/lflang/generator/python/PythonGenerator.java Outdated Show resolved Hide resolved
@Soroosh129 Soroosh129 merged commit 21cb9d0 into master Jun 14, 2022
@Soroosh129 Soroosh129 deleted the python-methods branch June 14, 2022 02:47
@Soroosh129 Soroosh129 added enhancement Enhancement of existing feature python Related to the Python target labels Jul 1, 2022
@lhstrh lhstrh changed the title Python methods Added support for Python methods Jul 7, 2022
@lhstrh lhstrh added feature New feature and removed enhancement Enhancement of existing feature labels Jul 7, 2022
@lhstrh lhstrh changed the title Added support for Python methods Support for Python methods Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
feature New feature python Related to the Python target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soroosh129 @edwardalee @lhstrh