-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design for reset symbols in diagrams #1241
Conversation
There is no guarantee that the required unicode planes will be available in the used system font, see #1219
This looks very cool! One concern I have is that the reset arrow might be hard to spot on the state. Would it make sense to wrap the reset arrow all the way around the bullet rather than have it dangle off the side? |
I also thought about this but my feeling is that this would make the "bullet point" too large, resulting in a very inconsistent appearance with others. |
The aspect ratio between the thickness of the arrow and the size of the dot is not quite as I meant, but here is a mock up of what it could look like: I'm basically suggesting that the outer circle around the filled dot can be replaced by an arrow. That way, it would take up about as much space as an ordinary state icon. |
Ah, now I get it. Yes, this is a good a idea. I will redesign it accordingly. |
Maybe lose the dot in the middle of the reset bullet? This might make it look cleaner and distinguish it better (and also match the event icon better). |
Hm, I'm unsure about this one. I agree that the new version relates more obviously to the |
I agree with @lhstrh, in the previous version the similarities between the sate variables were stronger, which also was my initial intention, to make the reset "only" a minor modification. |
Yes, I see this point... let's revert. |
This reverts commit 5ddc8d2.
Ok, I reverted the commit. We are back to the previous appearance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Fixes use of unicode symbols in state variables and revises reset trigger figure.
Closes #1219
Result:
for