Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History transitions are now indicated using the history keyword #1247

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Jun 23, 2022

Changes keyword for history transitions from continue to history.
The documentation is updated by website PR #87.
Update of the syntax highlighting for VSCode in vscode PR #62.

Also adds warning if the user does not specify a transition type but the types would actually have different effects on the target mode.

Closes #1220

@a-sr a-sr added enhancement Enhancement of existing feature modal models labels Jun 23, 2022
@a-sr a-sr requested a review from lhstrh June 23, 2022 08:50
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'll merge this and merge the accompanying documentation PR as well.

@lhstrh lhstrh merged commit 9a76b4c into master Jun 24, 2022
@lhstrh lhstrh changed the title New keyword for history transitions Changed keyword for history transitions from continue to history Jun 24, 2022
@lhstrh lhstrh changed the title Changed keyword for history transitions from continue to history History transitions are now indicated using the history keyword Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature modal models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor issues with the syntax of modal reactors
2 participants