Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch that avoids NullPointerException in CompileActionHandler #1267

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Patch that avoids NullPointerException in CompileActionHandler #1267

merged 2 commits into from
Jul 8, 2022

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jul 1, 2022 •
edited by cmnrd
Loading

This patch is meant to fix #1263, but I am puzzled as to why the resource associated with the Xtext editor would ever be null.

Closes #1263

@lhstrh lhstrh requested review from a-sr and edwardalee July 1, 2022 22:13
edwardalee
edwardalee approved these changes Jul 2, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good workaround, but I'm not sure it will solve the root problem. Let's merge it and I will continue testing to see whether the behavior where the build button does nothing recurs.

a-sr
a-sr requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know why the resource of the editor could ever be null.
Maybe if the editor is empty and not backed by a file but I doubt this was the case here.

org.lflang.ui/src/org/lflang/ui/actions/CompileActionHandler.java Outdated Show resolved Hide resolved
@lhstrh lhstrh requested a review from a-sr July 6, 2022 05:46
@cmnrd cmnrd merged commit 5e4bf84 into master Jul 8, 2022
@cmnrd cmnrd deleted the fix-1236 branch July 8, 2022 07:17
@lhstrh lhstrh changed the title Avoid NPE in CompileActionHandler Patch that avoids NullPointerException in CompileActionHandler Jul 20, 2022
@lhstrh lhstrh added the bugfix label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-sr a-sr a-sr approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epoch reports error when compile succeeds
4 participants
@lhstrh @edwardalee @a-sr @cmnrd