Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that reactions consistently trigger banks #1289

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Conversation

edwardalee
Copy link
Collaborator

This fixes Reactions do not consistently trigger banks #1278.

Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Soroosh129
Copy link
Contributor

It looks like the multiport/TriggerDownstreamOnlyIfPresent.lf test is seg faulting.

@edwardalee
Copy link
Collaborator Author

Right. I'm on it. Testing a better fix now.

@edwardalee
Copy link
Collaborator Author

Need to convert this PR to a draft, but there appears to be no way to do that.

@cmnrd
Copy link
Collaborator

cmnrd commented Jul 12, 2022

Need to convert this PR to a draft, but there appears to be no way to do that.

The "convert to draft" button is hidden in the top sidebar, right under the list of reviewers and above "Assignees".

@edwardalee edwardalee merged commit 2f62939 into master Jul 12, 2022
@edwardalee edwardalee deleted the dual-bank-bugfix branch July 12, 2022 18:12
@lhstrh lhstrh added c Related to C target bugfix labels Jul 12, 2022
@lhstrh lhstrh changed the title Dual bank bugfix Ensure that reactions consistently trigger banks Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix c Related to C target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants