Inference of logical execution times of reactions #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see, then I will remove that part |
Fixed LET inference and added test
Soroosh129
suggested changes
Aug 9, 2022
| return this.let; | ||
| } | ||
|
|
||
| if (this.parent.isGeneratedDelay()) { |
There was a problem hiding this comment.
Should this be an error condition?
There was a problem hiding this comment.
Because when we get the action delay by after lf syntax, the delay exists in the 'Delay' reactor, which is the additional reactor for only delay. So, if the parent is in the generated delay condition, we thought it should return the TimeValue.ZERO.
org.lflang.tests/src/org/lflang/tests/compiler/LetInferenceTests.java
Outdated
Show resolved
Hide resolved
hokeun
approved these changes
Aug 9, 2022
|
@lhstrh I think it is ready to merge. |
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP with @CloverCho and @Wonseo-C to infer logical execution times in
ReactorInstance.FIXMEs: