Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Klighd version to 2.2 #1297

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Bump Klighd version to 2.2 #1297

merged 4 commits into from
Jul 20, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Jul 15, 2022

Updates the target platform to the latest Klighd release.

Important: With this change, the generated language/diagram server will only work with the upcoming (corresponding) klighd-vscode release.

a-sr added 2 commits July 15, 2022 16:38
These properties should not be included in communication between diagram
server and client.
@a-sr a-sr added the diagrams Problems with diagram synthesis label Jul 15, 2022
@a-sr a-sr requested a review from lhstrh July 18, 2022 09:09
@a-sr a-sr marked this pull request as ready for review July 18, 2022 09:09
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from the changes to the visibility modifiers, which, given the INTERNAL comments are probably necessary to accommodate some API...?

Co-authored-by: Marten Lohstroh <[email protected]>
@lhstrh lhstrh merged commit 5581f98 into master Jul 20, 2022
@lhstrh lhstrh added the upgrade label Jul 20, 2022
@cmnrd cmnrd deleted the klighd-bump branch March 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Problems with diagram synthesis upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants