Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with child dependencies in Rust fixed #1352

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Problem with child dependencies in Rust fixed #1352

merged 5 commits into from
Sep 9, 2022

Conversation

oowekyala
Copy link
Collaborator

Fix #1353

@oowekyala
Fix lf-lang/reactor-rs#17
cbe8d7f 
Effect-dependencies were not being correctly registered
for child port references.
@oowekyala
Merge branch 'master' into clem.fix-rust-bug
667ae72
@oowekyala oowekyala added the rust Related to the Rust target label Sep 7, 2022
@oowekyala oowekyala requested a review from jhaye September 7, 2022 09:41
cmnrd
cmnrd reviewed Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this orthogonal to #1228?

@cmnrd cmnrd added the bugfix label Sep 7, 2022
@jhaye
Copy link
Collaborator

jhaye commented Sep 7, 2022

It is.

jhaye
jhaye approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@jhaye jhaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code linked in the issue now works as expected.

@cmnrd cmnrd merged commit 6141063 into master Sep 9, 2022
@cmnrd cmnrd deleted the clem.fix-rust-bug branch September 9, 2022 14:11
@lhstrh lhstrh changed the title Fix problem with child dependencies in Rust Problem with child dependencies in Rust fixed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd left review comments

@jhaye jhaye jhaye approved these changes

Assignees
No one assigned
Labels
bugfix rust Related to the Rust target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reaction does not trigger dependency for Simultaneous code snippet from website
3 participants
@oowekyala @jhaye @cmnrd