Removal of unnecessary build dependency to address security exceptions #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
TimeLimit.lf timed out for Python, but I'm inclined to ignore it. It is possible that we do not need that test anymore.
Count3Modes.lf timed out for C. That test has some delays in it. I suspect that this timeout can also be safely ignored.
I do not understand why this works, but I'm thankful that it does. It fixes things on my machine as well.
lhstrh
approved these changes
Sep 15, 2022
lhstrh
changed the title
|
I also don't fully understand why this works. It was more like a lucky shot :) I read hear that |
|
🤷♂️ |
petervdonovan
added
exclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1363 (at least locally on my machine, let's wait for CI). I think the issue is that
org.eclipse.core.runtimehad a conflicting version. Interestingly, it seems to work fine if we just remove our own version specification and let gradle resolve the dependency from xtext.I am not sure if we would also need to make a similar change in the Maven configuration.
This fixes #1363