-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python tests #1456
Fix python tests #1456
Conversation
5d95d38
to
936604e
Compare
@@ -33,7 +33,6 @@ jobs: | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: '3.10' | |||
if: ${{ runner.os == 'Windows' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Christian might know this already, but just in case: This line (deleted in this PR) was added by me specifically to make the macOS tests pass. The GH Actions runners have Python pre-installed, so the existence of the extra Python seemed to confuse CMake. The test failures we are seeing know are probably the same as what blocked me for more than a month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are probably right here. The strange thing is that cmake does not even use the version installed by the github action (3.10), but uses some other version that it finds (3.8). I don't know how to resolve this... The default Python version in the MacOS runner is now 3.11 which our Python target is not compatible to. I will continue trial and error and see where it gets me...
Peter, you know the Python target better than me: What do you think how much effort it would be to actually fix the errors that we see popping up in CI when Python 3.11 is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that I made a mistake and excluded version 3.10, which explains why cmake selected version 3.8 (which seems to be preinstalled as well)
a6f44f9
to
7bb431b
Compare
It looks like it works fine when we specify a range of possible Python versions in the cmake script. @petervdonovan what do you think about this solution? Should we merge it? |
The LSP tests on Mac OS consistently fail. I tried 3 times. Run 1 and 3 have the same error, but in run 2 another error is reported. I am not sure if there is an actual problem lurking here, or if I just had bad luck with the LSP tests. |
|
Co-authored-by: Peter Donovan <[email protected]>
Never mind, it was just something silly -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
Fixes #1455.