MalleableStrings made human readable #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Dec 8, 2022
This change uncovered a subtle bug in the formatting logic. It is not very good that the formatter has so many subtle bugs. A fix is in progress but will involve reformatting several tests, which takes time (#1342). |
|
The test failure in the last commit was probably nondeterministic given that it a) did not appear in the commit before it and b) seems to be unrelated to any changes anywhere in this branch. I think it is pragmatic to merge this branch despite the test failure. (which is reported in #1502). |
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported by @edwardalee today which results in the following diagram:
