Support for Arduino CLI #1532
Merged
Support for Arduino CLI #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
requested changes
Jan 9, 2023
Co-authored-by: Marten Lohstroh <[email protected]>
Exception is CMakeLists.txt, which itself should not be in the map.
lhstrh
requested changes
Jan 23, 2023
|
Oh, there are also a bunch of conflicts with |
lhstrh
approved these changes
Jan 25, 2023
lhstrh
reviewed
Jan 27, 2023
lhstrh
requested changes
Jan 27, 2023
This reverts commit 57bed1d.
Follows template of Zephyr
lhstrh
reviewed
Jan 28, 2023
Co-authored-by: Marten Lohstroh <[email protected]>
…increase efficiency of all tests.
lhstrh
reviewed
Jan 28, 2023
| @@ -47,11 +48,14 @@ | |||
| import org.lflang.generator.LFGeneratorContext; | |||
| import org.lflang.generator.LFGeneratorContext.BuildParm; | |||
| import org.lflang.generator.MainContext; | |||
| import org.lflang.generator.GeneratorCommandFactory; | |||
lhstrh
reviewed
Jan 28, 2023
| import org.lflang.tests.Configurators.Configurator; | ||
| import org.lflang.tests.LFTest.Result; | ||
| import org.lflang.tests.TestRegistry.TestCategory; | ||
| import org.lflang.util.FileUtil; | ||
| import org.lflang.util.LFCommand; | ||
| import org.lflang.util.ArduinoUtil; |
lhstrh
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new Arduino 2.0 IDE release, the functionality that allowed us to use CMake (the avr compiler) has been abstracted away, prompting us to move to Arduino-CLI, the backbone of the Arduino build system. Arduino-CLI has limitation with regards to how to compile multilayered projects, but allows for lazy compilation in a specified src folder.
This PR uses Arduino specifications in the following workflow: LFC generated code is treated like an Arduino Sketch and the corresponding reactor-c files are placed in a src folder to be lazy compiled. To do this, I removed files that aren't used by Arduino that when compiled will cause redefinition errors and changed all includes using Regex to be relative links inside the src folder since Arduino doesn't support adding additional include paths.
To try this:
arduino-cli board listand record the Fully Qualified Board Name (FQBN) and portplatform: {name: arduino, board: <FQBN>}target propertyarduino-cli upload -b <FQBN> -p <port>Features implemented:
arduinoas the platform without specifying aboardorportwill only generate C code (as it works now), but print a message instructing the user how to obtain the information and provide it to LFboardandport,arduino-cliis invoked automatically (unless theno-compileflag is used)