Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for update Rust runtime #1546

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Check for update Rust runtime #1546

merged 2 commits into from
Jan 16, 2023

Conversation

oowekyala
Copy link
Collaborator

Fix #1544

cmnrd
cmnrd approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I will add the comments you made on the diff directly as comments to the gradle file.

org.lflang/build.gradle Show resolved Hide resolved
org.lflang/build.gradle Show resolved Hide resolved
@cmnrd cmnrd merged commit 06fa27b into master Jan 16, 2023
@cmnrd cmnrd deleted the clem.fix-gradle-up2date-check branch January 16, 2023 09:26
@lhstrh lhstrh changed the title Fix #1544 - up to date check for updateRustRuntime Check for update Rust runtime Jan 26, 2023
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust submodule gets modified when running build-lf-cli
3 participants
@oowekyala @cmnrd @lhstrh