Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for port access to contained generic reactors in C++ #1547

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Bugfix for port access to contained generic reactors in C++ #1547

merged 1 commit into from
Jan 16, 2023

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jan 13, 2023

This provides a simple bugfix and adds a new testcase

@cmnrd
Fix port access to contained generic reactors in C++
4df733a 
This provides a simple bugfix and adds a new testcase
petervdonovan
petervdonovan approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I also saw your request response example that requires it and will look at it. Thanks!

@cmnrd cmnrd merged commit 03c5fe8 into master Jan 16, 2023
@cmnrd cmnrd deleted the fix-cpp-generic branch January 16, 2023 09:21
@lhstrh lhstrh changed the title Fix port access to contained generic reactors in C++ Bugfix for port access to contained generic reactors in C++ Jan 26, 2023
@lhstrh lhstrh added the bugfix label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

@tanneberger tanneberger Awaiting requested review from tanneberger

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmnrd @petervdonovan @lhstrh