Useful error message upon encountering missing runtime sources #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have an error message in lfc, that notified the user if the runtime files are missing (i.e. the submodules are not checked out). It seems that with the introduction of `FileUtil` this feature got lost. It currently only complains if a resource cannot be found at all, but not if the resource is an empty directory. Aside from a bit of cleanup, this fix ensures that a useful error message is also produced if a submodule is missing.
lhstrh
approved these changes
Jan 27, 2023
lhstrh
changed the title
lhstrh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have an error message in lfc, that notified the user if the runtime files are missing (i.e. the submodules are not checked out). It seems that with the introduction of
FileUtilthis feature got lost. It currently only complains if a resource cannot be found at all, but not if the resource is an empty directory. Aside from a bit of cleanup, this fix ensures that a useful error message is also produced if a submodule is missing.This depends on lf-lang/lf-lang.github.io#121. Without merging it, the link in the error message will not be available.