Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI args propagated to federates #1604

Merged
merged 4 commits into from
Feb 25, 2023
Merged

CLI args propagated to federates #1604

merged 4 commits into from
Feb 25, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Feb 24, 2023

Fixes #1598.

@lhstrh lhstrh marked this pull request as ready for review February 24, 2023 06:38
@lhstrh lhstrh requested a review from petervdonovan February 24, 2023 06:38
@lhstrh lhstrh mentioned this pull request Feb 24, 2023
Closed
@lhstrh lhstrh requested a review from edwardalee February 24, 2023 06:40
petervdonovan
petervdonovan approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge as-is. I left a minor comment, and I suppose that bad things can happen with the new default merging behavior. But I'm happy trying this behavior and seeing if it behaves mostly the way people want until lingo is in place

org.lflang/src/org/lflang/federated/generator/FedGenerator.java Outdated Show resolved Hide resolved
edwardalee
edwardalee approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo test failures (?).

@lhstrh lhstrh added the bugfix label Feb 25, 2023
@lhstrh lhstrh merged commit 90bbf72 into master Feb 25, 2023
@lhstrh lhstrh deleted the fix-1598 branch February 25, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command-line argument -n/--no-compile for lfc not working for federated programs
3 participants
@lhstrh @edwardalee @petervdonovan