Types allowed in reactor type args #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename type params to type args where appropriate
27 tasks
|
Thanks for taking a shot at this! I have struggled with it a couple of times, but never made the change. |
lhstrh
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Fantastic! This is a great improvement. Thank you, @oowekyala!
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows writing
new R<std::vector<int>>(...)without needing curly braces around the type argument. This is appropriate since it's a type argument (so, a type), not a type parameter. It was surprising that it's possible to write egstd::optional<int>without escaping in a type annotation anywhere in LF, except in that place. See for example a use case here:https://github.com/lf-lang/examples-lingua-franca/blob/e1dd212f28a4ccaf7ff6d717a488a113c5b466a4/Cpp/src/RequestResponse/MAC.lf#L26
Also rename type params to type args where appropriate, for consistency's sake.
Ref #1492 (grammar cleanups)