Remove klighd dependency and excludes org/lflang/diagram from gradle compilation #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
force-pushed
the
klighd-workaround
branch
from
2541a95 to
ef3bc82
Compare
|
I am surprised that the LSP tests actually run without the diagrams. Maybe we should merge this? |
|
We're not testing the diagrams, which also explains the dip in code coverage that we had after factoring out Epoch... |
|
Yes, but the lsp has a dependency on the diagramms, so I am surprised that it compiles without them. Or are wie still using the old build mechanism and not gradle for building the lsp? |
|
Merging this so that things can build again... |
lhstrh
added a commit
that referenced
this pull request
Mar 20, 2023
Revert "Merge pull request #1660 from lf-lang/klighd-workaround"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround for the gradle compilation issues that currently appear as the klighd dependency cannot be resolved. I hope we can fix it soon in other ways, but if there is no quick fix we might need to merge this workaround. This will break the language server though...