Enclave connections and enclave coordination in the C++ target #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanneberger
approved these changes
Apr 21, 2023
org.lflang/src/org/lflang/generator/cpp/CppConnectionGenerator.kt
Outdated
Show resolved
Hide resolved
this simplifies the connection procedure. Instead of generating different code for normal, enclaved, or just delayed connections, we use the same code for all and insert a lambda that is called to instantiate the concrete connection.
cmnrd
changed the title
cmnrd
force-pushed
the
enclave-connections
branch
from
a25e609 to
f2d73f1
Compare
cmnrd
force-pushed
the
enclave-connections
branch
from
f2d73f1 to
1e0dd75
Compare
cmnrd
force-pushed
the
enclave-connections
branch
from
1e0dd75 to
aae5cae
Compare
tanneberger
approved these changes
May 11, 2023
| | std::unique_ptr<$reactorType> __lf_instance{nullptr}; | ||
| | | ||
| | $enclaveWrapperClassName(const std::string& name, reactor::Reactor* container, $reactorType::Parameters&& params) { | ||
| | if (__lf_env == nullptr) { |
There was a problem hiding this comment.
general question the code generator generates c++ code in a totally different style like what is currently standard in reactor-cpp. __lf_env compared it would be probably be named lf_env_ in the style of reactor-cpp.
There was a problem hiding this comment.
We use the __lf_ prefix for some variables to avoid name clashes. It is unlikely, but if someone would name their state variable or some other reactor component lf_env_, we would see compile errors. __ is kind of a protected namespace in C/C++ that is not supposed to be used by users.
| reaction(in) {= | ||
| received = true; | ||
| auto value = *in.get(); | ||
| reactor::log::Info() << "Received " << value; |
There was a problem hiding this comment.
I like this that we now have native logging. Maybe we just need some alias for more handier use.
cmnrd
force-pushed
the
enclave-connections
branch
from
9ff7169 to
48898a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the C++ target with support for connections between enclave. Most of the functionality is added in lf-lang/reactor-cpp#44 which most importantly introduces three new connection types:
EnclaveConnection,DelayedEnclaveConnection, andPhysicalEnclaveConnection. This PR mostly updates the code generator such that the corresponding enclave connection type is inserted into the generated code if an enclave is involved in the connection. This PR also pulls in lf-lang/reactor-cpp#45 which prevents a race condition between staring enclaves.There remain open issues which will be covered in feature PRs: