Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revised mechanism for handling the files target property #1700

Merged
merged 16 commits into from
Apr 29, 2023
Merged

Revised mechanism for handling the files target property #1700

merged 16 commits into from
Apr 29, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Apr 15, 2023 •
edited
Loading

This PR cleans up the way we handle the files target property.

Fixes #1685.
Fixes #1719.

@lhstrh lhstrh marked this pull request as ready for review April 28, 2023 05:27
@lhstrh lhstrh requested a review from edwardalee April 28, 2023 16:17
@lhstrh lhstrh mentioned this pull request Apr 28, 2023
Closed
edwardalee
edwardalee approved these changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have verified that (after merging in master) examples/C/rhythm/RhythmDistributed.lf now works.

@lhstrh lhstrh merged commit 11e6379 into master Apr 29, 2023
@lhstrh lhstrh deleted the fed-files branch April 29, 2023 21:02
@lhstrh lhstrh mentioned this pull request May 5, 2023
Merged
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
2 participants
@lhstrh @edwardalee