Improved line adjustment logic for federated programs #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The resulting unit test failures are a bit puzzling... |
It is bad that I had to modify ToLf to do this since the logic isn't really in ToLf. The problem was that the line adjustment relies on tagging the target code (without the fat braces), and the target code is not recorded separately from the fat braces if they are entered into the MalleableString machinery as all one string.
petervdonovan
force-pushed
the
fix-fed-line-adjustment
branch
from
1e9297d to
c44f91e
Compare
petervdonovan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which, when a reaction body of a federated reactor all fits on one line, it does not get a (correct)
CodeMap.Correspondencetag. This issue was observed here.It is bad that I had to modify ToLf to do this since the logic isn't really in ToLf. The problem was that the line adjustment relies on tagging the target code (without the fat braces), and the target code is not recorded separately from the fat braces if they are entered into the MalleableString machinery as all one string.