Fix warnings reported on CliBase. #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison of strings to string literals looks like a critical error which I think would have been caught by sufficient tests. One of these warnings is incorrect, but we might as well silence it with an assertion. The warning about toArray is merely a matter of best practice. A human couldn't be expected to know about this, but the warning emitted by IntelliJ is correct.
lhstrh
approved these changes
May 28, 2023
|
Now that we have formatting addressed, we should also introduce linting and enforce that the code is warning free. I opened #1806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison of strings to string literals looks like a critical error which I think would have been caught by sufficient tests.
One of these warnings is incorrect, but we might as well silence it with an assertion.
The warning about toArray is merely a matter of best practice. A human couldn't be expected to know about this, but the warning emitted by IntelliJ is correct.
I'm not sure I have time to add tests for this at the moment or to do a close second read of this code but we also don't want to leave wrong code sitting around.