Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic params allowed as generic arguments in C target #1804

Merged
merged 10 commits into from
Jun 2, 2023
Merged

Generic params allowed as generic arguments in C target #1804

merged 10 commits into from
Jun 2, 2023

Conversation

petervdonovan
Copy link
Collaborator

Allow parameters of generic reactors to syntactically appear as arguments of contained reactors.

@petervdonovan petervdonovan marked this pull request as ready for review May 31, 2023 22:43
@petervdonovan petervdonovan linked an issue Jun 1, 2023 that may be closed by this pull request
[C-Generics] Hashed Filename missmatch #1780
Closed
@petervdonovan petervdonovan requested a review from lhstrh June 1, 2023 03:09
@petervdonovan petervdonovan enabled auto-merge June 1, 2023 03:22
lhstrh
lhstrh reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only nitpicks...

org.lflang/src/org/lflang/generator/c/TypeParameterizedReactor.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/TypeParameterizedReactor.java Show resolved Hide resolved
org.lflang/src/org/lflang/generator/c/CUtil.java Show resolved Hide resolved
@lhstrh lhstrh disabled auto-merge June 2, 2023 07:59
@lhstrh lhstrh merged commit cb9fa1d into master Jun 2, 2023
@lhstrh lhstrh deleted the generic-params-as-arguments branch June 2, 2023 07:59
@petervdonovan petervdonovan changed the title Generic params as arguments Allow use of generic params as generic arguments Aug 26, 2023
@petervdonovan petervdonovan added the feature New feature label Aug 26, 2023
@petervdonovan petervdonovan changed the title Allow use of generic params as generic arguments Allow use of generic params as generic arguments in C target Aug 26, 2023
@lhstrh lhstrh changed the title Allow use of generic params as generic arguments in C target Generic params allowed as generic arguments in C target Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C-Generics] Hashed Filename missmatch
2 participants
@petervdonovan @lhstrh