Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for race condition in uniqueName #1815

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Fix for race condition in uniqueName #1815

merged 2 commits into from
Jun 3, 2023

Conversation

petervdonovan
Copy link
Collaborator

Addresses this CI failure.

@petervdonovan petervdonovan requested a review from erlingrj June 3, 2023 16:55
@petervdonovan petervdonovan enabled auto-merge June 3, 2023 16:55
lhstrh
lhstrh approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes sense. Apologies for not catching this in code review!

@petervdonovan petervdonovan merged commit a06d23b into master Jun 3, 2023
@cmnrd cmnrd deleted the thread-safe-uniquename branch June 8, 2023 07:44
@petervdonovan petervdonovan changed the title Make uniqueName thread-safe Fix for race condition in uniqueName Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@erlingrj erlingrj Awaiting requested review from erlingrj

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petervdonovan @lhstrh