More formatter fixes #1850
Merged
More formatter fixes #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs another pass of optimization. Yes, this is totally a hacky heuristic, but it should not affect idempotency nor other correctness criteria. This can affect performance, but I modified the formatter to keep track of whether anything has changed so that it knows whether further optimization passes have the potential to give any improved results.
Previously any messages (even just info messages!) would stop the formatter from being run, which is an unnecessary requirement. If we can understand the AST, we can format it.
lhstrh
approved these changes
Jun 16, 2023
petervdonovan
force-pushed
the
more-formatter-fixes
branch
from
b1d830f to
c8b9f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs another pass of optimization. This is a heuristic, but it should not affect idempotency nor other correctness criteria. This can affect performance; however, I modified the formatter to keep track of whether anything has changed so that it knows whether further optimization passes have the potential to give any improved results, so in this common case the performance is not worse. When I ran it on my machine it did not seem much slower than before (around 30 seconds).
Also, when running the formatter from VS Code, we should go ahead even if there are warning or info messages, or syntax errors in the target code. If we can understand the AST, we can pretty-print it.