Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for extra whitespace around info messages #1879

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix for extra whitespace around info messages #1879

merged 2 commits into from
Jul 4, 2023

Conversation

oowekyala
Copy link
Collaborator

Fix #1867

The end of the log of LFC looks like this now:

[100%] Linking C executable DoubleReaction
[100%] Built target DoubleReaction
Install the project...
-- Install configuration: "Release"
lfc: info: SUCCESS: Compiling generated code for DoubleReaction finished with no errors.
lfc: info: Compiled binary is in /home/clem/Documents/LF/lingua-franca/test/C/bin
lfc: info: Code generation finished.

cmnrd
cmnrd approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for fixing this!

lhstrh
lhstrh approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for the fixes, @oowekyala!

@lhstrh lhstrh added this pull request to the merge queue Jul 3, 2023
Merged via the queue into lf-lang:master with commit 1f6398a Jul 4, 2023
@oowekyala oowekyala deleted the clem.fix-info-messages branch July 4, 2023 08:28
@petervdonovan petervdonovan changed the title Fix extra whitespace around info messages Fix for extra whitespace around info messages Aug 26, 2023
@petervdonovan petervdonovan added the enhancement Enhancement of existing feature label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@cmnrd cmnrd cmnrd approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many messages
4 participants
@oowekyala @cmnrd @lhstrh @petervdonovan