More robust dev scripts and removed util directory #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also turns out that there was a major bug in the readlink logic. I honestly don't know why this passed tests before. Edit: Actually, I do know: The tests passed before because both the launch scripts and the link structure crated in cli-test is 2 levels deep. It resolved the wrong path, but the end result was correct coincidentally... |
cmnrd
changed the title
lhstrh
reviewed
Sep 8, 2023
lhstrh
approved these changes
Sep 8, 2023
😮 🤯 |
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the util directory. By removing the utli directory, I hope to reduce the incentive on dumping unfurnished code and experimental tools in the main LF repo.
The only content of util at the moment are the launch helper scripts. This PR removes the launch scripts and instead implements the logic directly in the
lf*-devscripts. This adds a bit of code duplication (the readlink logic), but also simplifies other aspects of the script. Overall, the new solution should be more robust.This PR also adds back the capability to run the
lf*-devscripts from anywhere in the filesystem. This was removed by #1988.Finally, this PR also fixes bugs in the way we handled scripts before.