-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated C schedulers++ #2037
Conversation
…d remove deprecated C schedulers
…ove-deprecated-schedulers
We need to remove or fix GEDF_NP as well. It drops events with federated execution, possibly because deadlines are not correctly propagated upstream (reaction order dependencies are ignored). Even if this is fixed, it does very little because it only prioritizes deadlines per level. |
Then I propose we remove it and leave it as an open issue to fix it and bring back into main. Currently I am seeing some wierd level errors in CI on the single federated test that hardcodes the usage of the adaptive scheduler... |
@edwardalee I could take a stab at fixing the GEDF scheduler if you can provide a test case where it fails. Even if it "only" prioritizes reactions after deadline this is still an important feature. E.g. your example with a pipeline sense->process->act with a deadline on |
There is a test case in this issue. It is actually my sense->process->act example that fails. |
…ingua-franca into c-remove-deprecated-schedulers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this!
I'm confused. Didn't Erling fix the issue in another PR instead? |
The fixes are already merged into |
This PR does two things:
Closes #2009