Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output path specified in JSON used correctly #2088

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Output path specified in JSON used correctly #2088

merged 1 commit into from
Nov 7, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Nov 6, 2023

This is to accommodate interactions with lingo, which specifies an output directory in JSON.

@lhstrh lhstrh added the bugfix label Nov 6, 2023
@lhstrh lhstrh requested a review from axmmisaka November 6, 2023 18:54
@lhstrh lhstrh mentioned this pull request Nov 6, 2023
Closed
@lhstrh
Copy link
Member Author

lhstrh commented Nov 6, 2023 •
edited
Loading

After this has been merged, @edwardalee, install the nightly cli, check out https://github.com/lf-lang/lingo, install it using cargo install --path ., and then run cd sandbox and lingo build.

@lhstrh lhstrh requested a review from tanneberger November 6, 2023 19:03
@lhstrh lhstrh enabled auto-merge November 6, 2023 19:04
@lhstrh lhstrh requested review from edwardalee and removed request for axmmisaka November 6, 2023 19:04
edwardalee
edwardalee approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lhstrh lhstrh added this pull request to the merge queue Nov 7, 2023
Merged via the queue into master with commit aad140f Nov 7, 2023
41 checks passed
@lhstrh lhstrh deleted the out-from-json branch November 7, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@tanneberger tanneberger Awaiting requested review from tanneberger

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhstrh @edwardalee