Use more explicit include guards for Arduino #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that this is only a problem for Arduino because Arduino brings in header files that are not actually #included. This solution is a little bit of a hack because it should not be necessary to add this extra #ifndef, but it solves the problem and it should be mostly harmless for users that do not target Arduino.
petervdonovan
force-pushed
the
arduino-fix
branch
from
9b7d3fb to
1603d7e
Compare
|
It's a clever solution! I like it! It might be worth also generating a comment explaining the use of this extra include guard... |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this is only a problem for Arduino because Arduino brings in header files that are not actually
#included. This solution is a little bit of a hack because it should not be necessary to add this extra#ifndef, but it solves the problem and it should be mostly harmless for users who do not target Arduino.Closes #2062. Note that the test case originally used in #2062 would not have worked because Arduino Uno does not have enough memory for our runtime.