Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for TypeScript in dev mode #2130

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Bugfix for TypeScript in dev mode #2130

merged 3 commits into from
Dec 28, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Dec 12, 2023

Ensures that when an alternative reactor-ts runtime is pointed to, it is actually used.

@lhstrh lhstrh added the bugfix label Dec 13, 2023
@lhstrh lhstrh requested a review from hokeun December 14, 2023 17:07
@lhstrh lhstrh enabled auto-merge December 14, 2023 17:08
@lhstrh lhstrh requested a review from byeonggiljun December 14, 2023 22:16
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Collaborator

@byeonggiljun byeonggiljun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh lhstrh added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 19, 2023
@hokeun hokeun added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 20, 2023
@hokeun hokeun added this pull request to the merge queue Dec 20, 2023
@lhstrh lhstrh removed this pull request from the merge queue due to a manual request Dec 20, 2023
@lhstrh lhstrh merged commit a19002c into master Dec 28, 2023
43 checks passed
@lhstrh lhstrh deleted the ts-dev-mode branch December 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants