Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zephyr's CMake extension to correctly build and link reactor-c #2167

Merged
merged 12 commits into from
Jan 27, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Jan 26, 2024

We had experienced some issues with linking both reactor-c and the user-generated app to the Zephyr project. It is resolved by using Zephyrs cmake extension to create the reactor-c lib.

Also to avoid a name collision I have renamed the library from core to reactor-c.

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwardalee edwardalee added this pull request to the merge queue Jan 27, 2024
Merged via the queue into master with commit 36b3d4a Jan 27, 2024
43 checks passed
@edwardalee edwardalee deleted the zephyr-esp-issue branch January 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants