Tests that were previously failing re-enabled #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for review. It moves everything out of federated/failing, redesigning some to not flake, and making the ones that can still flake much more lax. At least they will check features compiling and running. |
petervdonovan
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Once my comment about EnclaveFederatedRequestStop.lf is addressed then I think this is ready to merge.
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts and moves federated tests that were previously failing into the regular test category because they should no longer be failing. These test use decentralized coordination, which is inherently timing dependent, and hence the tests could still be flaky. However, I have tuned the tests to tolerate timing variability, and hence we should not see flaky test failures. If we due, then further tuning is needed.
This PR also fixes issue #2161.
This also fixes an unrelated minor issue with the Python code generator where it would sometimes generate blank lines, which would cause random failures in the LSP tests.