Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchdogs to environment struct #2172

Merged
merged 23 commits into from
Feb 14, 2024
Merged

Add watchdogs to environment struct #2172

merged 23 commits into from
Feb 14, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Jan 28, 2024

These changes move the watchdogs to the environment struct and thus make the watchdog compatible with the future enclave support. The corresponding changes in reactor-c also address the termination issue for the watchdogs as described in #2150

See the corresponding reactor-c PR : lf-lang/reactor-c#341

@erlingrj erlingrj marked this pull request as draft January 28, 2024 20:52
@erlingrj erlingrj added enhancement Enhancement of existing feature c Related to C target labels Jan 28, 2024
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except one possible flaw identified. Is it a flaw?

@erlingrj erlingrj marked this pull request as ready for review February 13, 2024 09:12
@erlingrj erlingrj requested a review from edwardalee February 13, 2024 09:12
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The LSP test failure is probably unrelated (these tests are randomized) and probably due to the code generator generating blank lines, which the Python validator in the LSP doesn't like but the Python interpreter apparently has no problem with.

@edwardalee edwardalee enabled auto-merge February 13, 2024 18:41
@edwardalee edwardalee added this pull request to the merge queue Feb 14, 2024
@lhstrh lhstrh removed this pull request from the merge queue due to a manual request Feb 14, 2024
@lhstrh lhstrh merged commit 86dac48 into master Feb 14, 2024
42 of 43 checks passed
@lhstrh lhstrh deleted the watchdog branch February 14, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Related to C target enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants