-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watchdogs to environment struct #2172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except one possible flaw identified. Is it a flaw?
This enables Zephyr to pre-allocate stacks for the watchdog threads.
Add failing test with watchdogs and banks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The LSP test failure is probably unrelated (these tests are randomized) and probably due to the code generator generating blank lines, which the Python validator in the LSP doesn't like but the Python interpreter apparently has no problem with.
These changes move the watchdogs to the environment struct and thus make the watchdog compatible with the future enclave support. The corresponding changes in reactor-c also address the termination issue for the watchdogs as described in #2150
See the corresponding reactor-c PR : lf-lang/reactor-c#341