Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path conversion on Windows #2174

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fixed path conversion on Windows #2174

merged 1 commit into from
Feb 1, 2024

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jan 31, 2024

Fixes #2166

@cmnrd cmnrd added the bugfix label Jan 31, 2024
@cmnrd cmnrd requested a review from lhstrh January 31, 2024 17:25
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish all our fixes were this simple. Looks good, but I'm puzzled by the Zephyr failure. Tagging @erlingrj.

@lhstrh lhstrh enabled auto-merge January 31, 2024 19:46
@lhstrh lhstrh added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@lhstrh
Copy link
Member

lhstrh commented Jan 31, 2024

Looks like the strange macOS compilation issue is rearing its head again. We have trouble reproducing it locally -- it seems to only occur in CI, probably because those machines are under heavy load all the time. Maybe we should just disable macOS tests until this problem is fixed. It's already held up the release considerably, and now again we can't merge.

@lhstrh lhstrh merged commit 63ea131 into master Feb 1, 2024
43 checks passed
@lhstrh lhstrh deleted the fix-windows-paths branch February 1, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Diagram Synthesis
2 participants