Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to CLOCK_REALTIME for C target + cleanup #2184

Merged
merged 18 commits into from
Feb 11, 2024
Merged

Change to CLOCK_REALTIME for C target + cleanup #2184

merged 18 commits into from
Feb 11, 2024
+154 −154

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Feb 5, 2024 •
edited
Loading

This PR does two things:

  1. Introduce required changes in lfc to support this merged PR: Move to CLOCK_REALTIME introduce clock.h and lf_atomic.h reactor-c#346
  2. Remove a bunch of printf warnings from the C integration tests

@erlingrj erlingrj added enhancement Enhancement of existing feature c Related to C target cleanup labels Feb 5, 2024
@erlingrj erlingrj marked this pull request as draft February 5, 2024 19:16
@erlingrj erlingrj marked this pull request as ready for review February 11, 2024 15:34
@erlingrj erlingrj requested a review from edwardalee February 11, 2024 15:34
lhstrh
lhstrh approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @erlingrj. And thanks for addressing these long-standing printf warnings.

@lhstrh lhstrh merged commit 1d0deeb into master Feb 11, 2024
43 of 55 checks passed
@lhstrh lhstrh deleted the clock-realtime branch February 11, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee Awaiting requested review from edwardalee

Assignees
No one assigned
Labels
c Related to C target cleanup enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @lhstrh