Escape special characters in type arguments. #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves multiple FIXMEs in the code as well as issue #2179.
petervdonovan
force-pushed
the
escape-type-arg-special-chars
branch
from
c11505c to
f983c1b
Compare
I think this is OK; this test is inherently both a generics test and a CCpp test (because the special characters come from using C++), so it seems fine to put it in either category. But it should be in the target category so that it is not run on Windows.
petervdonovan
force-pushed
the
escape-type-arg-special-chars
branch
from
96de53c to
258755a
Compare
lhstrh
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves multiple FIXMEs in the code as well as issue #2179.