-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of deprecated APIs in C tests #2190
Conversation
…6824e1836fb0 of reactor-c
This PR is ready for review. There is a companion PR in reactor-c that requires a further companion review in the benchmarks repo in order to get all tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Looks like the right thing to do. It implies that the next version should be |
Yes, I'm also focused on a much-needed code cleanup pass. I could use some help figuring out how to get Doxygen to give a reasonable layout of the documentation web pages. The pages themselves are getting much better, but the layout is absurd. |
@arengarajan99 worked on this a while ago but hit roadblocks because the code itself wasn't well organized. That situation has improved a lot since then, so I'm curious whether his attempt could be reinvigorated. On the versioning: I think that we should plan a 1.0 version more carefully and release it only once we can confidently consider it stable... We can choose to strictly follow semantic versioning rules from v1.0 and on... |
This PR is a companion to 353 in reactor-c, which removes deprecated API macros originally used in reaction bodies in the C target.