Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin API for tracing #2192

Merged
merged 24 commits into from
Feb 27, 2024
Merged

Plugin API for tracing #2192

merged 24 commits into from
Feb 27, 2024

Conversation

petervdonovan
Copy link
Collaborator

@petervdonovan petervdonovan commented Feb 13, 2024 •
edited
Loading

See the companion PR in reactor-c for discussion. The changes that were required here to make the reactor-c changes work are relatively minor.

@lhstrh lhstrh added the feature New feature label Feb 14, 2024
@petervdonovan petervdonovan mentioned this pull request Feb 15, 2024
Merged
8 tasks
@petervdonovan
Copy link
Collaborator Author

This branch now works when called like so:

lfc-dev --tracing --json '{"src": "test/C/src/HelloWorld.lf", "properties": { "trace-plugin": "/path/to/tracing-client-api/target/debug/libmock_lf_trace_plugin.a" }}'

(The trace implementation provided in this example (from the tracing-client-api repo) is not open-sourced currently.)

Both this and its companion PR are finally ready to merge.

@petervdonovan petervdonovan requested a review from lhstrh February 26, 2024 18:54
lhstrh
lhstrh requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good and I'm happy that the handling of the target property is so clean. I left a minor comment that I think should be addressed before merging this.

core/src/test/java/org/lflang/tests/compiler/LinguaFrancaValidationTest.java Outdated Show resolved Hide resolved
lhstrh
lhstrh approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@lhstrh lhstrh enabled auto-merge February 27, 2024 05:50
@lhstrh lhstrh added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 5997ca5 Feb 27, 2024
24 checks passed
@lhstrh lhstrh deleted the tracing-refactoring2 branch February 27, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petervdonovan @lhstrh