Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lf_combine_deadline_and_level function #2226

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

edwardalee
Copy link
Collaborator

This PR suppresses a warning (below) and consolidates the mechanism that is used to combine a deadline with a level into a single C function. As usual, there is a companion PR in reactor-c. The warning was as follows:

/Users/edwardlee/git/epoch/org.lflang.ui/src/org/lflang/ui/wizard/templates/c/src-gen/Pipeline/Pipeline.c:562:91: warning: signed shift result (0x7FFFFFFFFFFFFFFF0000) requires 80 bits to represent, but 'long' only has 64 bits [-Wshift-overflow]
            pipeline_rp_self[pipeline_rp_i]->_lf__reaction_0.index = (9223372036854775807 << 16) | pipeline_rp_reaction_1_levels[pipeline_rp_i];
                                                                      ~~~~~~~~~~~~~~~~~~~ ^  ~~
1 warning generated.

@edwardalee edwardalee requested a review from lhstrh March 3, 2024 19:47
@edwardalee edwardalee added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit b8466aa Mar 6, 2024
24 checks passed
@edwardalee edwardalee deleted the combine-deadline-and-level branch March 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants