Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the compiler-flags target property #2233

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Mar 6, 2024

This removes the compiler-flags property. This property is not used in any of our examples or tests at the moment. Also, when used, we show a warning that it shouldn't be used because it interferes with cmake. So I think it's best to simply remove this property.

lf-lang/lf-lang.github.io#243 updates the documentation accordingly.

@cmnrd cmnrd added c Related to C target cleanup labels Mar 6, 2024
@cmnrd cmnrd requested review from edwardalee, lhstrh and erlingrj March 6, 2024 13:04
cmnrd added a commit to lf-lang/lf-lang.github.io that referenced this pull request Mar 6, 2024
This updates the documentation in accordance with lf-lang/lingua-franca#2233
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Compiler-flags can easily be added with cmake-include so no need for extra generality!

@lhstrh lhstrh changed the title Removed the compiler-flags target property Removal of the compiler-flags target property Mar 6, 2024
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@cmnrd cmnrd enabled auto-merge March 7, 2024 09:50
@cmnrd cmnrd added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 07cf4ba Mar 7, 2024
24 checks passed
@cmnrd cmnrd deleted the remove-compiler-flags branch March 7, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Related to C target cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants